breaking: remove preserve option #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kaisermann
reviewed
Dec 18, 2023
| return { code: '', map: '' }; | ||
| }, | ||
| }); | ||
| it('should NOT preprocess unrecognized languages', async () => { |
There was a problem hiding this comment.
It seems that I forgot how the auto preprocessor is working 😅 I didn't remember it's skipping unknown languages 🤔
There was a problem hiding this comment.
At some point in the past it wasn't, but it's nice that it is now. Saved me from having to implement it!
I think it's not really that it's skipping unknown languages but that it's looking at the lang field, so you can specify whatever you want in type since it's not using that field. Then since this doesn't specify a lang it gets skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #305
closes #312
Turns out the
preserveoption doesn't actually do anything useful anymore because it's now looking atlangand nottypeas it was originally. The original issues are already fixed without specifyingpreserveat all.