fix: Adjust globalifySelector to not split selectors with parentheses. #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregschmit
force-pushed
the
gns/fix-globalify-selector
branch
from
d6d1064
to
3a719d5
Compare
|
Update: I added a test that shows the problem and it fails in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
I ran into an issue where I could not use simple tailwind apply directives for dark mode and also couldn't import Daisy UI. I tracked it down to a problem with
svelte-preprocesscreating:globalrules that svelte is not happy with. User https://github.com/MagDevX suggested an adjustment toglobalifySelector.jscombinatorPatternto prevent selectors with parenthesis from being split.