Skip to content

Commit

Permalink
fix: don't warn on writes to $state (#11540)
Browse files Browse the repository at this point in the history
fixes #10905
  • Loading branch information
dummdidumm committed May 10, 2024
1 parent 6522336 commit 31f8fea
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/calm-buses-clap.md
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: don't warn on writes to `$state`
5 changes: 4 additions & 1 deletion packages/svelte/src/compiler/phases/2-analyze/index.js
Expand Up @@ -1242,6 +1242,7 @@ const common_visitors = {
if (
context.state.analysis.runes &&
node !== binding.node &&
context.state.function_depth === binding.scope.function_depth &&
// If we have $state that can be proxied or frozen and isn't re-assigned, then that means
// it's likely not using a primitive value and thus this warning isn't that helpful.
((binding.kind === 'state' &&
Expand All @@ -1252,7 +1253,9 @@ const common_visitors = {
!should_proxy_or_freeze(binding.initial.arguments[0], context.state.scope)))) ||
binding.kind === 'frozen_state' ||
binding.kind === 'derived') &&
context.state.function_depth === binding.scope.function_depth
// We're only concerned with reads here
(parent.type !== 'AssignmentExpression' || parent.left !== node) &&
parent.type !== 'UpdateExpression'
) {
w.state_referenced_locally(node);
}
Expand Down
Expand Up @@ -6,6 +6,11 @@
console.log(obj);
console.log(count);
console.log(doubled);
// these are ok because they're writes
count++;
count = 1;
obj.a++;
obj.a = 1;
</script>

<button onclick={() => count += 1}>
Expand Down

0 comments on commit 31f8fea

Please sign in to comment.