chore: add derived effect ownership tests (#11538)

* chore: add derived effect ownership tests * chore: add derived effect ownership tests
sveltejs · May 10, 2024 · 4ea8a5e · 4ea8a5e
1 parent f219c79
commit 4ea8a5e
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 2 deletions.
diff --git a/packages/svelte/src/internal/client/reactivity/deriveds.js b/packages/svelte/src/internal/client/reactivity/deriveds.js
@@ -121,7 +121,6 @@ export function update_derived(derived, force_schedule) {
  */
 export function destroy_derived(signal) {
 	destroy_derived_children(signal);
-	destroy_effect_children(signal);
 	remove_reactions(signal, 0);
 	set_signal_status(signal, DESTROYED);
 

diff --git a/packages/svelte/tests/signals/test.ts b/packages/svelte/tests/signals/test.ts
@@ -8,7 +8,7 @@ import {
 	user_effect
 } from '../../src/internal/client/reactivity/effects';
 import { source, set } from '../../src/internal/client/reactivity/sources';
-import type { Derived } from '../../src/internal/client/types';
+import type { Derived, Value } from '../../src/internal/client/types';
 import { proxy } from '../../src/internal/client/proxy';
 import { derived } from '../../src/internal/client/reactivity/deriveds';
 
@@ -376,4 +376,51 @@ describe('signals', () => {
 			assert.equal(teardown, 1);
 		};
 	});
+
+	test('creating effects within a derived correctly handles ownership', () => {
+		const log: Array<number | string> = [];
+		let a: Value<unknown>;
+		let inner: Value<string | number>;
+		let outer: Value<string | number>;
+
+		const destroy = effect_root(() => {
+			inner = source(0);
+			outer = source(0);
+
+			render_effect(() => {
+				a = derived(() => {
+					log.push('outer', $.get(outer));
+					effect(() => {
+						log.push('inner', $.get(inner));
+					});
+				});
+			});
+		});
+
+		return () => {
+			flushSync(() => {
+				$.get(a);
+			});
+			assert.deepEqual(log, ['outer', 0, 'inner', 0]);
+			log.length = 0;
+			flushSync(() => {
+				set(inner, 1);
+				$.get(a);
+			});
+			assert.deepEqual(log, ['inner', 1]);
+			log.length = 0;
+			flushSync(() => {
+				set(outer, 1);
+				$.get(a);
+			});
+			assert.deepEqual(log, ['outer', 1, 'inner', 1]);
+			log.length = 0;
+			flushSync(() => {
+				set(inner, 2);
+				$.get(a);
+			});
+			assert.deepEqual(log, ['inner', 2]);
+			destroy();
+		};
+	});
 });