Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fetchpriority to image attrs #10390

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 4, 2024

This is a version of #10388 for Svelte 4

This PR adds the fetchpriority attribute to HTML attributes. This has been requested in #8099, which was rejected as an experimental feature. It is now implemented in Chromium and Safari, and is in the WhatWG spec.

I am the maintainer of @unpic/svelte (recommended in the docs ), and currently need to add it as an augmented property. It would be good if we could add it instead.

Fixes #8099

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 4, 2024

🦋 Changeset detected

Latest commit: c2ca4f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit c15e021 into sveltejs:svelte-4 Feb 5, 2024
2 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants