Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable inspector #10531

Merged
merged 1 commit into from Feb 19, 2024
Merged

disable inspector #10531

merged 1 commit into from Feb 19, 2024

Conversation

Rich-Harris
Copy link
Member

i love the inspector normally but so much of the time spent in the preview site locally is in the editor, where it's just false-positive-o-rama. deeply annoying

Copy link

changeset-bot bot commented Feb 18, 2024

⚠️ No Changeset found

Latest commit: 151827e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@PuruVJ PuruVJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont feel need for it much. Also triggers falsely for me when taking a screenshot

@Rich-Harris Rich-Harris merged commit 9c8e643 into main Feb 19, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the disable-inspector branch February 19, 2024 13:06
@dominikg
Copy link
Member

ouch, you could have just removed true, setting it to false force disables it for everyone. You can also disable it from your env or change your preferred key kombo.

also happy to change the default combo on mac if screenshot is conflicting....

@ryanatkn
Copy link
Contributor

ryanatkn commented Feb 19, 2024

@dominikg I think the shortcuts should be reconsidered for Linux/Windows too, in Chrome ctrl+shift+C is "inspect element" which for me is a very common conflict. The Mac default of meta+shift is working fine for me on Linux/Windows, I'm sure there's a good reason for this but I couldn't find background on this except the Mac screenshot issue - sveltejs/vite-plugin-svelte#557 Not sure if this is a good idea, but maybe making any key clear the Svelte inspector would solve these and other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants