Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svelte:component props are not properly updated when there are spread props #10604

Merged
merged 4 commits into from Feb 22, 2024
Merged

Fix svelte:component props are not properly updated when there are spread props #10604

merged 4 commits into from Feb 22, 2024

Conversation

konstantinov90
Copy link

@konstantinov90 konstantinov90 commented Feb 22, 2024

fix 10602

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Alexander Konstantinov added 2 commits February 22, 2024 16:54
Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 47de201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thank you, looks good! Could you add a changeset (using npx changeset at the root of the repo)? Then we're good to merge.

@konstantinov90
Copy link
Author

changeset done

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.changeset/popular-wombats-try.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 055e7a8 into sveltejs:svelte-4 Feb 22, 2024
6 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
@konstantinov90
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants