Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use a setInterval demo #10747

Merged
merged 3 commits into from Mar 11, 2024
Merged

docs: use a setInterval demo #10747

merged 3 commits into from Mar 11, 2024

Conversation

Rich-Harris
Copy link
Member

as per #10745, it's better not to use a console.log example here. Instead, we can actually show why you might need to use a cleanup function

Copy link

changeset-bot bot commented Mar 10, 2024

⚠️ No Changeset found

Latest commit: 8cb9e88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new example is nice, but it would be even better to have a button there that changes the miliseconds ("go faster" that cuts the miliseconds in half maybe), so see the "reruns when miliseconds change" in action.

@dummdidumm dummdidumm merged commit 5086ef4 into main Mar 11, 2024
8 checks passed
@dummdidumm dummdidumm deleted the effect-docs-3 branch March 11, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants