Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support parsing camel case in container queries #11131

Conversation

tanhauhau
Copy link
Member

Fixes #10845

The eatIdent(...) method from css-tree somehow expects lowercase identifiers only, and thus not working for camel case container names. switching to a more generic eat(Ident) would work. Since we already know the current token is an identifier with the name, we dont have to assert the content of the identifier via eatIdent()

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 06e7180

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tanhauhau tanhauhau force-pushed the tanlh/fix/support-css-container-queries-camelcase branch from e9576c6 to 06e7180 Compare April 11, 2024 14:45
@trueadm trueadm merged commit 41eb8da into sveltejs:svelte-4 Apr 12, 2024
6 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants