Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bind:group #11256

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+21 −4
Draft

fix bind:group #11256

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42f9626
fix bind:group
Apr 20, 2024
c032b47
revert unnecessary change
Rich-Harris May 15, 2024
26e9636
Merge branch 'main' into pr/11256
Rich-Harris May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 21 additions & 4 deletions packages/svelte/src/internal/client/dom/elements/bindings/input.js
View file
Open in desktop
Expand Up @@ -81,13 +81,29 @@ export function bind_group(inputs, group_index, input, get_value, update) {
var value = input.__value;

if (is_checkbox) {
value = get_binding_group_value(binding_group, value, input.checked);
let initial = get_value()
if (!Array.isArray(initial)) initial = []
value = get_binding_group_value(binding_group, value, input.checked, initial);
}

update(value);
},
// TODO better default value handling
() => update(is_checkbox ? [] : null)
() => {
if (is_checkbox) {
let initial = get_value()
if (!Array.isArray(initial)) initial = []
var value = new Set(initial);

for (const input of binding_group) {
value.delete(input.__value);
}

update(Array.from(value));
} else {
update(null);
}
}
);

render_effect(() => {
Expand Down Expand Up @@ -146,10 +162,11 @@ export function bind_checked(input, get_value, update) {
* @param {Array<HTMLInputElement>} group
* @param {V} __value
* @param {boolean} checked
* @param {Array<V>} initial
* @returns {V[]}
*/
function get_binding_group_value(group, __value, checked) {
var value = new Set();
function get_binding_group_value(group, __value, checked, initial) {
var value = new Set(initial);

for (var i = 0; i < group.length; i += 1) {
if (group[i].checked) {
Expand Down