Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow sequence expressions in @const tags #11357

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

dummdidumm
Copy link
Member

closes #11349

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 28, 2024

🦋 Changeset detected

Latest commit: 4eb3e94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jrmajor
Copy link
Contributor

jrmajor commented Apr 28, 2024

This will throw an error for {@const foo = ('bar', 'baz')}, which I don't think should be forbidden. I've also started working on this issue and created a test for that, but don't really have an idea how to get it to pass, because parentheses are not present in AST. Feel free to cherry pick it from 495c1a5 :)

@fry69
Copy link

fry69 commented Apr 28, 2024

It is a bit weird to see the comma operator getting used outside a for loop, but it is valid JavaScript.

@Rich-Harris Rich-Harris merged commit 5e0845f into main Apr 29, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the const-sequence branch April 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: @const treats multiple declarations as sequence expression
4 participants