Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure reactions are kept dirty when marking them again #11364

Merged
merged 1 commit into from Apr 29, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Apr 28, 2024

previously a reaction could be marked as DIRTY and subsequently as MAYBE_DIRTY before running, resulting in false negatives. Ensure that DIRTY flag can never be lowered to MAYBE_DIRTY
fixes #11363
fixes #11352
fixes #11368

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

previously a reaction could be marked as DIRTY and subsequently as MAYBE_DIRTY before running, resulting in false negatives. Ensure that DIRTY flag can never be lowered to MAYBE_DIRTY
fixes #11363
Copy link

changeset-bot bot commented Apr 28, 2024

🦋 Changeset detected

Latest commit: 94ad6ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti
Copy link
Contributor

Uh i guess this could be the reason my #11290 has a failing test...will try to run it again after this is merged.

@MotionlessTrain
Copy link

I have the feeling that this may also fix #11352

@dummdidumm
Copy link
Member Author

Indeed it does, thanks for flagging!

@trueadm trueadm merged commit de315d8 into main Apr 29, 2024
8 checks passed
@trueadm trueadm deleted the reactions-dirty-fix branch April 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants