Better process effects #11560
Merged
Better process effects #11560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 58145ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
May 11, 2024
dummdidumm
reviewed
May 11, 2024
| // We might be dealing with many effects here, far more than can be spread into | ||
| // an array push call (callstack overflow). So let's deal with each effect in a loop. | ||
| for (var i = 0; i < effects.length; i++) { | ||
| if ((filter_flags & EFFECT) !== 0) { |
There was a problem hiding this comment.
Why is the if condition inside the for loop? It looks like it isn't dependent on the content so can be switched
There was a problem hiding this comment.
What do you mean? Feel free to put up a PR to show what you mean. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11532.