Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap props in deriveds more conservatively in legacy mode #11571

Closed
wants to merge 2 commits into from

Conversation

Rich-Harris
Copy link
Member

See #11548 (comment). This fixes #11448 by wrapping props in deriveds in legacy mode, unless they're trivial

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 12, 2024

🦋 Changeset detected

Latest commit: 5f19c37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Is this the right or wrong angle? I.e. should a parent component be the one to decide how the child component receives prop updates, or should it be the child component? I.e. if a runes component uses a legacy component, should the legacy component be the one saying "I only update on an object prop change"? I'm unsure.
Granted, this way around is easier to implement.

@Rich-Harris
Copy link
Member Author

Ah yeah, you're right. I had a crack at implementing it that way round in #11574 but there's a failing test that I cannot for the life of me get to the bottom of

@Rich-Harris
Copy link
Member Author

closing in favour of #11577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: store updates trigger component prop changes that didn't with 4
3 participants