Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Event to globals list #3810

Merged
merged 1 commit into from Oct 28, 2019
Merged

Add Event to globals list #3810

merged 1 commit into from Oct 28, 2019

Conversation

Joxtacy
Copy link
Contributor

@Joxtacy Joxtacy commented Oct 27, 2019

Changes

Add Event to the list of globals.

Background

When trying to create new Event(), the compiler complains that Event is not defined.

Relates to #3805

Tests

  • Run the tests tests with npm test or yarn test

There are at least more events that could be added and possibly even more things, but I figured I'd start with this one at least.

@Rich-Harris Rich-Harris merged commit 292017c into sveltejs:master Oct 28, 2019
@Rich-Harris
Copy link
Member

thanks 👍

@Joxtacy Joxtacy deleted the add_event_to_globals_list branch October 28, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Joxtacy @Rich-Harris