Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach binding_group into array #4881

Closed

Conversation

tanhauhau
Copy link
Member

an attempt on #2308

instead of a component-level $$binding_groups to track all the different binding groups,
how about attaching $$binding_groups into the bind:group={array}'s array?

that way we can pass the array around, and we can have app-level bind:group

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau tanhauhau mentioned this pull request May 21, 2020
4 tasks
@tanhauhau tanhauhau marked this pull request as draft June 2, 2020 00:34
@tanhauhau tanhauhau closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant