Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint warnings caused by recent ESLint configuration update #5031

Closed
wants to merge 2 commits into from
Closed

fix lint warnings caused by recent ESLint configuration update #5031

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
354ab15
lint for the lint gods
jgravois Jun 17, 2020
52eee5e
instead of a custom rule, make the change upstream
jgravois Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,9 @@ module.exports = {
'estree'
],
'svelte3/compiler': require('./compiler')
},
// workaround for https://github.com/typescript-eslint/typescript-eslint/issues/1824 and rely solely on 'indent' rule
rules: {
"@typescript-eslint/indent": "off"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change this in the common config:

https://github.com/sveltejs/eslint-config/blob/e8a9b27cd3f7aa66388474412b1a5c11c5a44ade/index.js#L31

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. i've opened sveltejs/eslint-config#1 and removed the custom rule i proposed initially here in 52eee5e.

}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prior to making this change, it was not possible to use --fix to resolve the lint warnings reported by 'indent' itself.

this leads me to believe that 'indent' and '@typescript-eslint/indent" are at an impasse as to what the appropriate indentation should be. given the language in typescript-eslint/typescript-eslint#1824, it seemed safest to side with 'indent'.

};