Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update acorn and parse expression as module script #5423

Merged
merged 4 commits into from Sep 18, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5422
Fixes #5407

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

With this PR and with {import.meta.url} in the template, the compiler gives missing-declaration warnings about import and (strangely) meta. I don't know whether we want to handle this by adding import to the known globals, or whether we want to special-case this, and I also don't know why it's warning us about meta.

@antony
Copy link
Member

antony commented Sep 18, 2020

I think import.meta is for this specific purpose, for magic Schrodinger's variables and such, so it should probably be special cased?

@tanhauhau
Copy link
Member Author

hmm.. let me add a test case to make sure that it didnt have warning. 🤔

@Conduitry Conduitry merged commit aef5671 into sveltejs:master Sep 18, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants