Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitelist open attribute for <details/> in attribute selector #5425

Merged
merged 3 commits into from Sep 18, 2020
Merged

whitelist open attribute for <details/> in attribute selector #5425

merged 3 commits into from Sep 18, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5421

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau changed the title whitelist open attribute for <details/> whitelist open attribute for <details/> in attribute selector Sep 18, 2020
@Conduitry Conduitry merged commit b5b02f8 into sveltejs:master Sep 18, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
whitelist [open] attribute selector for <details> (sveltejs#5425)
8af1800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused CSS rule for open attribute thrown away during compile time but should not be thrown away
2 participants
@tanhauhau @Conduitry