Refactor SourceMap and Preprocessor tests #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Milan Hauth <milahu@gmail.com>
dummdidumm
approved these changes
Oct 25, 2020
benmccann
reviewed
Oct 25, 2020
| @@ -37,7 +37,7 @@ | |||
| "posttest": "agadoo internal/index.mjs", | |||
| "prepublishOnly": "npm run lint && PUBLISH=true npm test", | |||
| "tsd": "tsc -p src/compiler --emitDeclarationOnly && tsc -p src/runtime --emitDeclarationOnly", | |||
| "lint": "eslint '{src,test}/**/*.{ts,js}'" | |||
| "lint": "eslint \"{src,test}/**/*.{ts,js}\"" | |||
There was a problem hiding this comment.
I'm not sure I would have changed this line
There was a problem hiding this comment.
It wasn't really related to the sourcemap/preprocessor test changes, but I think it is necessary for linting to work on Windows.
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Oct 29, 2020
* upstream/master: (140 commits) support $$props and $$restProps for custom elements (sveltejs#5608) Bump eslint-config to 5.5.0 (sveltejs#5599) update changelog add Node and Element as known globals (sveltejs#5601) docs: fix a11y warning in media elements example (sveltejs#5606) Curly braces linting fixes (sveltejs#5585) refactor sourcemap and preprocessor tests (sveltejs#5583) -> v3.29.4 fix code generation error with nullish coalescing operator and logical operators (sveltejs#5564) -> v3.29.3 -> v3.29.2 -> v3.29.1 docs: fix a11y warning in media elements tutorial (sveltejs#5523) update changelog get context at start of {#if} update block instead of at the end (sveltejs#5531) update changelog only allow passing functions to lifecycle functions (sveltejs#5529) update changelog fix compiler hanging on <slot slot="..."> (sveltejs#5536) Add svelte@next caveat to bug report template (sveltejs#5561) ...
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Co-authored-by: Milan Hauth <milahu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is a mild refactor of the sourcemap and preprocessor samples
Why
It paves the way for the implementation of Source Map support in Svelte Preprocessors (#5015 & #5428 & #5182),
How
It introduces preprocessor sourcemap handling to the sourcemap and preprocessor test samples, and refactors the arguments to the tests to allow easier testing of the new functionality.
Who
This is pulled from the excellent work done by @milahu as part of #5428 in order to make the changes easier to review.