Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] a11y: add aria-proptype validation #6316

Closed
wants to merge 1 commit into from

Conversation

davemo
Copy link
Contributor

@davemo davemo commented May 9, 2021

As per #820, this is an attempt to begin adding support for validating aria-proptypes.

I'm starting small because I wanted to open a PR as a discussion point to verify that I'm going about this the right way. I suspect if the approach looks good it will be easy to continue to add support for all the cases that are validated by the aria-query props map I just went ahead and finished the all the proptype validations 🤓

I had considered adding that library, but then saw that the core compiler seems to be fairly light on dependencies.

I wasn't sure how granular to make the test partitions seeing as there a large number of these proptypes, as a start I placed tests grouped into categories that the W3C taxonomy page lists: https://www.w3.org/TR/wai-aria/#state_prop_taxonomy

  • global
  • widget
  • live-region
  • drag-and-drop
  • relationship

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@davemo davemo changed the title add beginnings of aria-proptype validation to compiler, starting with… add beginnings of aria-proptype validation May 9, 2021
@davemo davemo changed the title add beginnings of aria-proptype validation a11y: add aria-proptype validation May 10, 2021
@pngwn pngwn added compiler Changes relating to the compiler and removed feature: a11y labels Jun 27, 2021
@benmccann benmccann changed the title a11y: add aria-proptype validation [feat] a11y: add aria-proptype validation Jun 30, 2021
@davemo
Copy link
Contributor Author

davemo commented Nov 6, 2021

Just jumping back in here to check on things, do I need to make any changes for this to be merged @benmccann @pngwn ? I'm happy to do whatever is needed 🤓

@tanhauhau
Copy link
Member

thanks for working on this.

There's another similar PR #6978 for adding aria-proptype validation as well, will merge that instead of this one.

@tanhauhau tanhauhau closed this Jul 11, 2022
@davemo davemo deleted the a11y/aria-proptypes branch July 11, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Changes relating to the compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants