Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] error when using combinator incorrectly #7650

Merged
merged 2 commits into from Jul 19, 2022
Merged

[fix] error when using combinator incorrectly #7650

merged 2 commits into from Jul 19, 2022

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Jul 2, 2022 •
edited

fixes #7643

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

baseballyama
baseballyama reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but maybe we should add more test cases as I commented.

src/compiler/compile/css/Selector.ts Show resolved Hide resolved
baseballyama
baseballyama approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tanhauhau tanhauhau merged commit 91b20b9 into sveltejs:master Jul 19, 2022
@tanhauhau tanhauhau deleted the tanhauhau/gh-7643 branch October 7, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baseballyama baseballyama baseballyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting a CSS rule with > breaks styling without producing an error
2 participants
@tanhauhau @baseballyama