Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slot binding on inner element read error in arrow function #7667

Merged
merged 4 commits into from Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/compile/nodes/shared/Expression.ts
Expand Up @@ -323,7 +323,7 @@ export default class Expression {

const func_expression = func_declaration[0];

if (node.type === 'InlineComponent') {
if (node.type === 'InlineComponent' || node.type === 'SlotTemplate') {
// <Comp let:data />
this.replace(func_expression);
} else {
Expand Down
@@ -0,0 +1,8 @@
<script>
export let log;
export let b;
function innerCall(a) {
log(`a: ${a}, b: ${b}`);
}
</script>
<slot name="inner_slot" {innerCall} />
@@ -0,0 +1,12 @@
<script>
import Inner from './Inner.svelte'
export let log;
export let a;
export let b;
</script>

<Inner {log} {b}>
<svelte:fragment let:innerCall slot="inner_slot">
<slot outerCall={() => innerCall(a)} />
</svelte:fragment>
</Inner>
27 changes: 27 additions & 0 deletions test/runtime/samples/component-slot-let-inline-function/_config.js
@@ -0,0 +1,27 @@
let logs;
function log(value) {
logs.push(value);
}

export default {
html: "<button>click me</button>",
props: {
a: 'a',
b: 'b',
log,
},
before_test() {
logs = [];
},
async test({ assert, component, target, window }) {
const button = target.querySelector("button");
await button.dispatchEvent(new window.MouseEvent("click"));

assert.deepEqual(logs, ["a: a, b: b"]);

component.a = '1';
component.b = '2';
await button.dispatchEvent(new window.MouseEvent("click"));
assert.deepEqual(logs, ["a: a, b: b", "a: 1, b: 2"]);
},
};
@@ -0,0 +1,12 @@
<script>
import Outer from "./Outer.svelte";
export let log = [];
export let a;
export let b;
</script>

<Outer let:outerCall {log} {a} {b}>
<button on:click={outerCall}>
click me
</button>
</Outer>