Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Apply class directive after half way transition #7765

Merged
merged 1 commit into from Aug 14, 2022
Merged

[fix] Apply class directive after half way transition #7765

merged 1 commit into from Aug 14, 2022

Conversation

baseballyama
Copy link
Member

fix: #7764

Class attributes were reset if outro existed and element had not yet been destroyed.
But class directive was not like that.
This PR fixed this issue.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@GauBen
Copy link
Contributor

GauBen commented Aug 7, 2022

This was fast! Thank you baseballyama

@baseballyama baseballyama merged commit 3570a53 into sveltejs:master Aug 14, 2022
@baseballyama baseballyama deleted the fix/7764 branch August 14, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class={thing1} overwrites class:thing2
3 participants