Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css-tree [WIP] #829

Merged
merged 1 commit into from Sep 8, 2017
Merged

Update css-tree [WIP] #829

merged 1 commit into from Sep 8, 2017

Conversation

Conduitry
Copy link
Member

csstree/csstree#47

This has apparently been addressed, and it looks like we can now import just the parser. (It looks like at some point between then and now we stopped using css-tree's walker and started using estree-walker for walking the AST?) This upgrade does increase the bundle size, but not as dramatically as alpha16 -> alpha17 would have.

I had to make one other change for a renamed property in order to get the tests to pass, but css-tree's changelog should be looked at more thoroughly.

@Conduitry
Copy link
Member Author

Conduitry commented Sep 8, 2017

Ref #408.

Also, the failed CI tests looked unrelated. Rebasing on latest master and hopefully that clears them up.

Edit: That ... did not help. I think we're good now

AttributeSelector.operator has been renamed to AttributeSelector.matcher
@Rich-Harris Rich-Harris merged commit 119e707 into master Sep 8, 2017
@Rich-Harris Rich-Harris deleted the update-css-tree branch September 8, 2017 11:52
@Rich-Harris
Copy link
Member

Nice! this is great news

@lahmatiy
Copy link

lahmatiy commented Sep 8, 2017

@Conduitry Do you count the difference in size?
I experimented with improvements on bundling of separate modules (parser for the beginning). Work still in progress (on pause at the moment), but I got ~35Kb for parser instead of ~58Kb (current size of build by browserify). I think the result can be improved. Anyway, for smaller size you will need to use a build version. Is it an option for you? Does further size reducing make sense for you?
//cc @Rich-Harris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants