chore: fix CI on Node 20

[baseballyama]

I think on Node20, we need to use pnpm@8.3.1.

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with feat:, fix:, chore:, or docs:.
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with npm test and lint the project with npm run lint

[vercel]

@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

[benmccann]

Why do you think this is necessary? The CI appears to me to be passing on Node 20. For example: https://github.com/sveltejs/svelte/actions/runs/4751810813/jobs/8441389746

[Conduitry]

pnpm/pnpm#6424 I was having this exact issue with pnpm and Node 20 in other unrelated projects. It was apparently caused by something in node-fetch and was resolved in pnpm 8.3.1 by forking node-fetch. I'm not sure why CI was passing without it. Does that still build the compiler in one version of Node and then run tests in another? I seem to recall that happening at one point when we wanted to use a version of Rollup that didn't run on Node 8.

[Conduitry]

Looking more closely at the GH action run you linked to, I do see some Node 18 floating around in the logs. I don't actually see Node 20 mentioned anywhere, but I haven't looked extremely closely.

[baseballyama]

Yeah, this action uses Node v18.15.0.

https://github.com/sveltejs/svelte/actions/runs/4751810813/jobs/8441389746#step:4:11

[benmccann]

Aha! No wonder we didn't see it on the CI. I sent a fix for that here: #8530

The other way of addressing this would be to drop support for Node 14 and then just use pnpm 8 everywhere. Node 14 will be EOL in a week, so that might be preferable

[benmccann]

#8530 passed on Node 20, so it appears pnpm 7.32.0 works with Node 20 and this PR isn't actually necessary

[Conduitry]

As I commented on #8530, I'm seeing the same issue on 7.32.0 locally as I am with 8 prior to 8.3.1. I suspect there's something being cached (either in the downloading or the installing of the packages) in GitHub actions that is concealing the issue. I would bet that if we tried upgrading any of the dependencies, we'd run into this same issue in CI in Node 20.