Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte.dev v2 #8578

Merged
merged 96 commits into from
Jun 16, 2023
Merged

svelte.dev v2 #8578

merged 96 commits into from
Jun 16, 2023

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented May 11, 2023

PR to merge into master/version-4 when this is ready. Opening as Draft. This should be a regular merge rather than Squash to preserve all the PR history

PuruVJ and others added 30 commits January 25, 2023 14:37
* Push

* Remove `rootDir`

* Use tsconfig instead of jsconfig

* Push recent changes

* Better dark mode

* empty commit to try and trigger a deploy

* bump kit

* Fix site-kit dep

* Comment out blurb

* Update site-kit to 3.2.1

* Externalise sourcemap-codec

* Install sourcemap-codec as dep

---------

Co-authored-by: Rich Harris <hello@rich-harris.dev>
* Rename markdown to blog

* Multi-page docs

* Ignore missing ID for now

* heading

* Add code snippets(temporary)

* /docs redirects to introduction

* Remove ukraine petition

* OnThisPage

* Remove console.log

* Update deps

* Fix accessibility warning

* Update site-kit
* Push

* Update svelte REPL

* Light mode fixes

* Fox height issues

* Moar dark mode fixes

* More changes

* Fix zen mode height issue
* Copy the right files

* Finish search

* FIx accessibility issues

* Add original site compatibility back in

* Remove console.log

* Reorganize imports

* Minor refactor

* Fix undefined heading issue

* Replace state on redirect

* Don't redirect to docs/introduction from navbar

* Cleanup search

* Cleanup some more(html entities)

* Remove console log

* Minor style tweaks

* Put search in middle
- use search components
- use shell component
* feat(docs): Local tutorial

* Refactor some stuff

* Better error handling

* Fix search imports

* Prerender tutorial

* try prerendering hack

* fix super stupid display hidden bug

* Shorten the rendered URL

* Shorten URL code even more
* feat(docs): Local tutorial

* Refactor some stuff

* Better error handling

* Fix search imports

* Prerender tutorial

* try prerendering hack

* fix super stupid display hidden bug

* Shorten the rendered URL

* Shorten URL code even more

* Prerender in svelte.config.js

* Refactor

* Fix ScreenToggle dark mode styles

* Initial POC

* Rvert to old hack

* Fix svelte-document.jpg
* Localize the examples dependents

* Localize FAQ

* Try to fix examples API

* Remove examples api

* Prerender, use vercel adapter, disable PUT action for now

* Don't call get_examples_data on top

* Move repl PUT to its own routew

* Don't prerender REPL page

* Change console warn

* Prerender tutorial the smart way

* Use getContext in root

* work around some weird content encoding glitch

* Try the pre-generate route

* Apply the suggestions

* Fix embed examples

* Remove comment

* remove commented-out code

* Update sites/svelte.dev/src/routes/_components/Demo.svelte

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>

* remove unused code

* add note to self, remove ts-ignore

* move adapter-vercel to devDependencies

* remove some unused deps

* huh we need flexsearch after all? weird

* we need sourcemap-codec as well — what the hell. are these deps missing from a dep?

---------

Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
)

* Update links

* Move blog to site/content

* Update site/content/docs/02-component-format.md

* Fix docs links

* Add global prettierrc

* Auto format

* Fix git merge artifact

* Fix errors

* Update html to svelte(remaining ones)

* Add 2 blog posts

* Modify prettierrc

* Minor design fix

* Switch package lock to spaces, prettier ignore

* Regenerate package lock

* prettier format

* Update deps

* Hack the build into working

* add missing blog post

---------

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <git@rich-harris.dev>
* Update links

* Move blog to site/content

* Update site/content/docs/02-component-format.md

* Fix docs links

* Add global prettierrc

* Auto format

* Fix git merge artifact

* Fix errors

* Update html to svelte(remaining ones)

* Add 2 blog posts

* Modify prettierrc

* Minor design fix

* Switch package lock to spaces, prettier ignore

* Regenerate package lock

* prettier format

* Push

* Remove console.logs

* Minor fixes

* Fix search

* Fix heading <code> style

* Fix search some more

* Code cleanup

* Update deps

* Move content around

* Allow drafts

* Redirect logic

* Don't render anything on docs if /docs

* Shorten the regex patterns

* Fix some more

* Hack the build into working

* Modernize docs links

* Add content to introduction

* Modify the content

* fix content links

* Reduce duplication in redirect regex

* Differences from Kit page

* Fix link

* Make OnThisPage visible on all docs

* Misc changes

* Move differences page to introduction

* Run prettier

* Prerender examples api routes

* Modify introdution page

* replace positions of readonly and get

* Minor blog style enhancement

---------

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Jun 14, 2023

Update on Rich's suggestions #8578 (comment)

Top section

PR: #8720. Here's how it looks:
CleanShot 2023-06-14 at 16 59 25@2x
CleanShot 2023-06-14 at 16 59 30@2x

Terminal

I believe @benmccann onto it?

Tutorial

I think linking everywhere to learn.svelte.dev is better, and on learn.svelte.dev, if webcontainers fail to load somehow, we can give them an option to come here to the corresponding page

Docs

Migrating from v3 to v4 is pending, we can probably drop that gist with the changes in here, or if someone wants to write one from scratch?

Examples

Do you think we can ship this before the launch? If not, @benmccann had the idea of a Playground page which sort of merges examples and REPL in a sidebar of sort

Blog

If I have time I can start designing this. Won't need to rush it to the launch, but would be good to have it either way

@vedam
Copy link
Member

vedam commented Jun 14, 2023

Shouldn't "Cybernetically..." not be uppercase?

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Jun 14, 2023

Making it match kit's style, which is fully lowercase

@vedam
Copy link
Member

vedam commented Jun 14, 2023

Hmmm... looks a bit weird lowercase with the higher letter-spacing IMO.

  1. Either go uppercase and change kit's underline accordingly (my preference),
  2. or go lowercase and set letter-spacing to normal.

As always, a subjective opinion.
IMO the uppercase version makes the whole thing up there a bit more compact.

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Jun 14, 2023

Changed letter-spacing to normal in the styling PR

CleanShot 2023-06-14 at 18 19 35@2x

* chore: playground (#8648)

* initialize playground

* pnpm up

* tidy up git ignore

* remove fluff

* format

* rm readme

* fix jsconfig error

* add skip-worktree instructions

* reload hack

* simplify

* use rollup

* ughh

* add flag for SSR

* ...

* simplify further

* configure launch.json

* add debugger info to readme

* remove vm modules flag

* use replaceAll instead of replace

* tidy up

* fix: make it run

* add watch to launch config

* Generate type declarations with `dts-buddy` (#8702)

* use dts-buddy

* remove debug output

* remove existing type generation script

* fix package.json

* update gitignore

* bump dts-buddy

* remove unused action entry point

* add svelte/compiler and svelte/types/compiler/preprocess modules

* bump dts-buddy

* annoying

* changeset

* bump dts-buddy

* get rid of .d.ts files

* another one

* Update packages/svelte/package.json

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>

---------

Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>

* fix: export ComponentType (#8694)

* fix: export ComponentType

* ughh

* changeset

* fix: derived types (#8700)

* fix: derived store types

* changeset

* Version Packages (next) (#8709)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* update type generation script

* remove unused stuff

* fix: changeset publish script isn't called release anymore (#8711)

* chore: remove prepare script (#8713)

* chore: fix release workflow (#8716)

* More readable, Fix $$_attributes

* Fix types (#8727)

* put comment in right place

* bump dts-buddy

---------

Co-authored-by: Rich Harris <git@rich-harris.dev>

* build types

* add svelte/compiler types

* remove prepare script

* fix

* typo

* squelch errors

* Add svelte and kit to twoslash's types field

* squelch more stuff

* Add errors to account for new types

* Remove deps

* formatting tweak

* fix linting, maybe

* the hell

* gah

* Fix types a bit

* bump dts-buddy

* pnpm generate in dev mode

* Cache again

* reduce index

* bump dts-buddy

* remove comment

---------

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dominik G <dominik.goepel@gmx.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Puru Vijay <devpuruvj@gmail.com>
Co-authored-by: Rich Harris <git@rich-harris.dev>
* DocsNav

* Push

* Nav title on each page

* Install jridgewell sourcemap codec. Why it breaking suddenly

* Use theme store

* Use $nav_title

* use $page.data.nav_title

* Disable global prerendering

* Fix Suppprters section

* use new method

* Initially hidden nav functionality

* Minor fixes

* Simplify into one single nav

* Accomodate to the bottom nav

* Minor fixes

* nit

* Add selected to other pages as well

* New way of passing to navbar

* Code cleanup

* Directly pass list instead of components

* 14 days

* Fix comment

* Discord icon

* Homepage styles

* More tweak, extra CTA

* Bigger lowercase tagline

* Preload overpass for transitions demo

* Tweak for ipad air

* Remove letter spacing

* simplify home page styles (#8738)

* simplify

* fix

* slightly better use of space

* tiny bit more room

* read the docs

* crop image

* very minor tweak

* another breakpoint

* tweak

* actually it works down to 1400px

---------

Co-authored-by: Rich Harris <git@rich-harris.dev>

---------

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <git@rich-harris.dev>
* bump site-kit

* bump again

---------

Co-authored-by: Rich Harris <git@rich-harris.dev>
note some inline, drive-by-fix in custom element docs
closes #8703
@benmccann benmccann merged commit bdf10f1 into version-4 Jun 16, 2023
6 of 7 checks passed
@benmccann benmccann deleted the sites branch June 16, 2023 15:45
@buhodev
Copy link
Contributor

buhodev commented Jun 21, 2023

Having the pieces move in the top section of the home page would look awesome and draw a lot of attention. I wonder if it can be implemented in Threlte (optimizing the model enough in order to overcome the drawbacks of not using an image in the first place). Also, it could fallback to an image when javascript is disabled.

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Jun 21, 2023

That's a good idea! We did consider that, but the cost of ThreeJS and overall complexity of the whole endeavour is not worth it, and extra page load times and potentially degraded performance(on lower end devices) would send the opposite message of what Svelte stands for: Simple, fast and inclusive(which includes lower end devices as well) 😁

@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants