Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply inert to outroing elements #8628

Merged
merged 1 commit into from
May 26, 2023
Merged

feat: apply inert to outroing elements #8628

merged 1 commit into from
May 26, 2023

Conversation

dummdidumm
Copy link
Member

That way they are invisible to assistive technology and can't be interacted with, which makes sense since the element is already "dead" and only transitioning out at this point. Strictly speaking that's a breaking change, so it's marked as such.

closes #8445

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

that way they are invisible to assistive technology and can't be interacted with, which makes sense since the element is already "dead" and only transitioning out at this point
closes #8445
@dummdidumm dummdidumm added this to the 4.x milestone May 24, 2023
@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) May 24, 2023 3:39pm

@dummdidumm dummdidumm merged commit 734cc19 into version-4 May 26, 2023
7 of 8 checks passed
@dummdidumm dummdidumm deleted the inert branch May 26, 2023 11:07
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants