Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup changesets #8668

Merged
merged 22 commits into from
Jun 1, 2023
Merged

chore: setup changesets #8668

merged 22 commits into from
Jun 1, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented May 30, 2023

This PR replaces @Conduitry with a robot as we all will be soon enough 馃

Thank you @Conduitry for your tireless work managing releases and keeping the changelog tidy!

I plan to separately add a changeset for #8658 after this is committed

@vercel
Copy link

vercel bot commented May 30, 2023

@benmccann is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

.changeset/config.json Outdated Show resolved Hide resolved
.changeset/config.json Outdated Show resolved Hide resolved
@dominikg
Copy link
Member

dominikg commented May 30, 2023

we have to verify that generating version.js happens and is correctly commited/tagged. see sveltejs/kit#9969 for a discussion around this.

posted on changesets: changesets/changesets#1166

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@tcc-sejohnson tcc-sejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l.g.t.m.
a l h o 
u i e n 
n n m o 
c t e t 
h e   o 
i d   n 
n     o 
g     u 
      s 

@benmccann
Copy link
Member Author

@tcc-sejohnson @dominikg one last thing I wanted to check on:

changeset version && pnpm -r generate:version && git add --all"

I'm not entirely sure what that's expected to cover. Right now packages/svelte/.gitignore has /src/shared/version.js. Is that okay or do we need to start checking this file into git?

@dominikg
Copy link
Member

@tcc-sejohnson @dominikg one last thing I wanted to check on:

changeset version && pnpm -r generate:version && git add --all"

I'm not entirely sure what that's expected to cover. Right now packages/svelte/.gitignore has /src/shared/version.js. Is that okay or do we need to start checking this file into git?

If we don't include it in git, then we can just rely on having it called during release. which is not ok in my opinion. I think all imports from our src to our src should be pointing at files in the repo.

This is partly why I was excited to see you calling build, so we could theoretically include the types here as well...

@tcc-sejohnson
Copy link
Contributor

@tcc-sejohnson @dominikg one last thing I wanted to check on:

changeset version && pnpm -r generate:version && git add --all"

I'm not entirely sure what that's expected to cover. Right now packages/svelte/.gitignore has /src/shared/version.js. Is that okay or do we need to start checking this file into git?

Ah yeah, it'd need to be checked into git. That or we could run pnpm -r generate:version prior to release?

@dominikg
Copy link
Member

checking those files into git would help getting rid of the prepare script too

@benmccann
Copy link
Member Author

Ok, I've added version.js to git

This is partly why I was excited to see you calling build, so we could theoretically include the types here as well...

Ah, I might have misunderstood that comment. I thought you were unhappy I was calling build 馃槅 The types seem a bit different. With those you'd probably want them generated alongside the PR that changed the function signature so that you can review them then instead of making it part of the release. But then we'd need some kind of check to ensure that's happening. I think I'll leave that for a separate PR if someone wants to take a stab at it

.changeset/config.json Outdated Show resolved Hide resolved
@dominikg
Copy link
Member

dominikg commented Jun 1, 2023

we still should make sure that all package.json files in this workspace that should not be published are private: true. this includes things like the playground or any other new package. changesets is relentless and will publish stuff if it's not on the registry.

benmccann and others added 2 commits June 1, 2023 13:03
@benmccann
Copy link
Member Author

we still should make sure that all package.json files in this workspace that should not be published are private: true

we're okay for now. there's only two package.json files currently and they're both set appropriately:

$ find . -name package.json
./packages/svelte/package.json
./package.json

@dominikg
Copy link
Member

dominikg commented Jun 1, 2023

#8648 adds the playground but that is private too 馃憤 just another thing to keep in mind during PR reviews. we won't be adding loads of package.json so the risk is relatively small

@benmccann benmccann merged commit f2ff684 into sveltejs:version-4 Jun 1, 2023
6 of 7 checks passed
@benmccann benmccann deleted the changesets branch June 1, 2023 20:22
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants