Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: use CustomEvent constructor instead of deprecated createEvent method #8775

Merged
merged 1 commit into from
Jun 21, 2023
Merged

breaking: use CustomEvent constructor instead of deprecated createEvent method #8775

merged 1 commit into from
Jun 21, 2023

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jun 21, 2023 •
edited by gtm-nayan

closes #7178
closes #8474

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm dummdidumm added this to the 4.x milestone Jun 21, 2023
@dummdidumm dummdidumm merged commit 203490c into master Jun 21, 2023
7 checks passed
@dummdidumm dummdidumm deleted the custom-event branch June 21, 2023 08:07
This was referenced Jun 21, 2023
Merged
Merged
@matubu matubu mentioned this pull request May 15, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtm-nayan gtm-nayan gtm-nayan approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use CustomEvent constructor instead of deprecated initCustomEvent()
2 participants
@dummdidumm @gtm-nayan