Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css sourcemap generation with unicode filenames #9120

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

gtm-nayan
Copy link
Contributor

fixes #6714

code-red will fail on such cases too, but that codepath doesn't seem to be hit by Svelte currently, if the error pops up again that'd be the place to look

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2023

🦋 Changeset detected

Latest commit: 4edc308

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gtm-nayan
Copy link
Contributor Author

/ecosystem-ci run

@svelte-ecoystem-ci
Copy link

svelte-ecoystem-ci bot commented Aug 20, 2023

📝 Ran ecosystem CI: Open

suite result
eslint-plugin-svelte ✅ success
language-tools ✅ success
mdsvex ✅ success
prettier-plugin-svelte ✅ success
rollup-plugin-svelte ✅ success
skeleton ✅ success
svelte-eslint-parser ❌ failure
svelte-loader ✅ success
svelte-preprocess ✅ success
sveltekit ✅ success
vite-plugin-svelte ✅ success

@gtm-nayan
Copy link
Contributor Author

eslint parser has been failing on master, should be fine

@dummdidumm dummdidumm merged commit ba1e678 into master Aug 20, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
@benmccann benmccann deleted the unicode-filenames-css branch August 22, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode dev error
2 participants