Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applying :global for +,~ sibling combinator when slots are present. fixes #9274 #9282

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

kelvinsjk
Copy link
Contributor

fixes #9274

For the following,

<div>
  <slot/>
  <span>xxx</span>
</div>

the style :global(p) + span could be applied because the slot could contain the required p element.

The current code did not apply the style because siblings.size===0 during compilation. To fix it, the existing find_previous_sibling and get_possible_element_siblings functions were modified to also return whether a sibling slot has been found. We only flag a css selector as inapplicable if, in addition to the existing checks on sibling size and parent, if there are no previous sibling that are slots found.

Svelte compiler rewrite

Please note that the Svelte codebase is currently being rewritten. Thus, it's best to hold off on new features or refactorings for the time being.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2023

🦋 Changeset detected

Latest commit: 067f18f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…sent and style directive is updated via an object prop"

This reverts commit 434bdeb.
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 9de149c into sveltejs:svelte-4 Apr 9, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Adjacent Sibling Combinator (+) is causing some CSS to be erroneously removed
2 participants