-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GamepadEventHandler type #9864
Conversation
Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
🦋 Changeset detectedLatest commit: d032ff4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1454,7 +1459,7 @@ export interface SVGAttributes<T extends EventTarget> extends AriaAttributes, DO | |||
z?: number | string | undefined | null; | |||
zoomAndPan?: string | undefined | null; | |||
|
|||
// allow any data- attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one found after just auto format
Need to fix lint issues :) |
Line success on my local. Seem like the Acron version update in this PR #9746 breaks the import Line 52 in 2f71c16
$ pnpm run lint
> svelte-monorepo@0.0.1 lint /home/ntsd/git/ntsd/svelte
> cd packages/svelte && pnpm build && cd ../../ && pnpm -r lint
> svelte@4.2.8 build /home/ntsd/git/ntsd/svelte/packages/svelte
> rollup -c && pnpm types
src/compiler/index.js → compiler.cjs...
(!) Circular dependencies
src/compiler/compile/render_dom/wrappers/Fragment.js -> src/compiler/compile/render_dom/wrappers/AwaitBlock.js -> src/compiler/compile/render_dom/wrappers/Fragment.js
src/compiler/compile/nodes/shared/map_children.js -> src/compiler/compile/nodes/AwaitBlock.js -> src/compiler/compile/nodes/PendingBlock.js -> src/compiler/compile/nodes/shared/map_children.js
src/compiler/compile/nodes/ThenBlock.js -> src/compiler/compile/nodes/shared/get_const_tags.js -> src/compiler/compile/nodes/shared/map_children.js -> src/compiler/compile/nodes/AwaitBlock.js -> src/compiler/compile/nodes/ThenBlock.js
...and 18 more
created compiler.cjs in 1.8s
> svelte@4.2.8 types /home/ntsd/git/ntsd/svelte/packages/svelte
> node ./scripts/generate-dts.js
Scope: 3 of 4 workspace projects
packages/svelte lint$ prettier . --cache --plugin-search-dir=. --check && eslint "{scripts,src,test}/**/*.js" --cache
│ Checking formatting...
│ All matched files use Prettier code style!
└─ Done in 5.1s |
The Acorn thing is unrelated and happening for a while now. I'll look into this the coming days |
Add GamepadEventHandler type for window.addEventListener
gamepadconnected
andgamepaddisconnected
Ref: https://developer.mozilla.org/en-US/docs/Web/API/GamepadEvent
Same with #9861 but merge to Svelte 4
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint