New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svelte-inspector interfering with OS screenshot shortcuts #557
Comments
What would be the alternative? Got something to propose? As it does not stop the functionality and it can be worked around rather easily. But if you have an idea of how to improve it and the DX, sure. As it is only happening when trying to screenshot a sveltekit app in dev mode the issue is rather minor IMO.
But again, what would be a good alternative ? |
It might be best to figure out a different default shortcut to avoid conflicts. I think it's important enough because it's common to take frequent screenshots for clients/coworkers/feedback Something that would help a bit is to handle it like this:
|
There's a way to set a custom key combination for the inspector: https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/config.md#inspector Hope this helps. |
I think |
got annoyed by this myself, here's a slight change in behavior based on #557 (comment) would be great if you could try #716 to see if it works on mac @probablykasper |
Unfortunately it doesn't fix it because the This problem is pretty specific to those shortcuts. I don't know any other shortcut with this problem, so combinations like Your PR still helps with other cases though, nice work! |
released svelte-inspector 1.0.4 with the improvements. That cmd-shift-(3,4,5) don't trigger key events and also don't cause onLeave leave us no room for detecting it. In this case there are 2 workarounds:
In the next major release we might reconsider the default shortcut for macos if more users raise their annoyance. |
Describe the bug
I frequently take screenshots, which on macOS is done using
cmd+shift+3/4
. When I do that, the inspector shows up and photobombs my screenshot, then it stays active afterwards.It's a bit disorienting to me because after pressing
cmd+shift+4
I now need to remember to do a separate shortcut to hide the inspector (I found myself tryingEscape
a lot).Screen.Recording.2022-12-16.at.06.06.01.converted.mp4
Reproduction URL
Not applicable here imo
Reproduction
npm create svelte
inspector
insvelte.config.js
:npm i && npm run dev
cmd+shift+4
Logs
No response
System Info
The text was updated successfully, but these errors were encountered: