fix(inspector): handle autocomplete keydown event #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome triggers a "keydown" event when autocompleting in forms, which causes a `event.getModifierState is not a function` error. This change makes sure that only keydown events with a defined key are checked.
bluwy
changed the title
bluwy
approved these changes
May 15, 2022
|
Thanks! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome triggers a "keydown" event when autocompleting in forms, which triggers a
event.getModifierState is not a functionerror.This change makes sure that only keydown events with a defined key are checked.
Related issue from another GitHub repo: paperjs/paper.js#1398
Screenshot of bug from my project:
