fix: ignore __vite-browser-external when trying to resolve svelte packages #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I thought we had wrapped a try-catch to prevent edge-cases like this from breaking dev/build 🤔 And with #362 already closed, do we still need this? |
|
Yes, to prevent the confusing error log |
|
Ah I see it's just the debug log from the issue, build was fine. Wouldn't hurt to add another check then 👍 |
bluwy
approved these changes
Jun 5, 2022
bluwy
approved these changes
Jun 5, 2022
Merged
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes a confusing error log but doesn't fix the underlying issue which is in vite itself. see #362