Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatic handling for kit.browser.hydrate config #368

Merged
merged 3 commits into from Jun 7, 2022
Merged

feat: automatic handling for kit.browser.hydrate config #368

merged 3 commits into from Jun 7, 2022

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Jun 7, 2022

This isn't really testable until kit stops passing configFile: false in inline options.

Manually ignoring that flag and removing the inline kit options show it works though.

@dominikg dominikg requested a review from benmccann June 7, 2022 20:44
benmccann
benmccann approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

packages/vite-plugin-svelte/src/utils/options.ts Outdated Show resolved Hide resolved
@dominikg dominikg requested a review from benmccann June 7, 2022 21:14
@dominikg dominikg merged commit 55314e5 into main Jun 7, 2022
@dominikg dominikg deleted the feat/read-kit-option branch June 7, 2022 21:31
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dominikg @benmccann