feat: bring prebundleSvelteLibraries out of experimental
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
changed the title
prebundleSvelteLibraries out of experimental
benmccann
force-pushed
the
enable-prebundling
branch
from
7111ac7
to
c473442
Compare
bluwy
reviewed
Oct 20, 2022
bluwy
approved these changes
Oct 20, 2022
bluwy
changed the title
prebundleSvelteLibraries out of experimentalprebundleSvelteLibraries out of experimental
dominikg
reviewed
Oct 21, 2022
|
If you feel comfortable promoting it out of experimental i'm ok with it too. One thing that can be a bit of a pain still is that if it discovers new svelte components while navigating an app during dev, prebundling runs again to include them unless you add all of them to optimizeDeps.include (which has to be done explicitly because there is no glob support in that (why not?) |
|
I think it would only re-prebundle when it discovers a new deep import, but this PR/feature should bring it closer to a Vite issue so maybe we can get glob support for Vite 4 too 🤔 Ref: vitejs/vite#5419 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hurray!
We can address #421 in a follow-up since it only makes prebundling less effective, but doesn't break any projects