New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable prebundling by default #494
Conversation
The guides and recommendations likely have to be rewritten as there are several factors at play. A) optimizeDeps currently does not work for ssr, leading to slow load times during dev when you import a large library without using deep imports There is no golden rule for what's right, just general recommendations:
picking between 2 and 3 has to be done by the users, v-p-s cannot decide that. To improve performance for index imports we can look into enabling optimizeDeps for build and ssr too, but unfortunately i havn't been able to get it running for ssr so far. |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs are organized well for me. Have some nits below:
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
… is enabled during build or ssr
…uild plugin for that so it does whatever, but won't break because of prebundleSvelteLibraries
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
enable prebundleSvelteLibraries by default
TODO: