Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove commonjs build #522

Merged
merged 5 commits into from Dec 7, 2022
Merged

feat!: remove commonjs build #522

merged 5 commits into from Dec 7, 2022

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Dec 6, 2022 •
edited

fixes #487

see faq if you need commonjs

bluwy
bluwy reviewed Dec 6, 2022
View reviewed changes
packages/vite-plugin-svelte/package.json Outdated Show resolved Hide resolved
packages/vite-plugin-svelte/package.json Outdated Show resolved Hide resolved
@bluwy
Copy link
Member

bluwy commented Dec 7, 2022 •
edited

side topic, i'm not sure if breaking: is a valid scope. i usually see it as feat!: or chore!: 🤔 (or maybe it's a different convention)

@dominikg dominikg changed the title breaking: remove commonjs build feat!: remove commonjs build Dec 7, 2022
@dominikg dominikg merged commit 956e381 into main Dec 7, 2022
@dominikg dominikg deleted the breaking/remove-cjs-output branch December 7, 2022 08:45
This was referenced Dec 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove cjs build of vite-plugin-svelte
2 participants
@dominikg @bluwy