Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional parameter types #797

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Fix optional parameter types #797

merged 3 commits into from
Nov 17, 2023
+12 −6

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 17, 2023

The parameter types are optional but since #751 it was accidentally marked required.

@bluwy
Fix optional parameter types

Verified

This commit was signed with the committer’s verified signature.
thaJeztah Sebastiaan van Stijn
GPG key ID: 76698F39D527CE8C
Verified
Learn about vigilant mode
446e17e
@bluwy
Copy link
Member Author

bluwy commented Nov 17, 2023

CI is failing because generate:types generates import("vite") but the formatter changes to import('vite') on commit 🙃 But we don't run the formatter before validating the types.

@dominikg dominikg merged commit 158a6d5 into main Nov 17, 2023
@dominikg dominikg deleted the optional-types branch November 17, 2023 13:24
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikg dominikg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluwy @dominikg