Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowers log level to debug #806

Conversation

Radiergummi
Copy link
Contributor

@Radiergummi Radiergummi commented Nov 20, 2023

This message isn't immediately actionable for developers and can reasonably be considered debugging output. Therefore, the log level has been updated to reflect this.

This fixes #803.

This message isn't immediately actionable for developers and can reasonably be considered debugging output. Therefore, the log level has been updated to reflect this.
@Radiergummi
Copy link
Contributor Author

@dominikg as requested; here goes. I was pretty confident you don't require tests for logging, so this PR is as bare-bones as it gets.

@dominikg
Copy link
Member

the PR also needs a changeset, you can create it with pnpm changeset and following the prompts. (select vite-plugin-svelte, select patch, write a short note like "changed loglevel of output unchanged message to debug to reduce verbosity")

Radiergummi and others added 2 commits November 20, 2023 16:17
This commit adds a debug section for "hmr" to the line, as suggested by @dominikg.

Co-authored-by: Dominik G. <dominik.goepel@gmx.de>
@Radiergummi
Copy link
Contributor Author

the PR also needs a changeset, you can create it with pnpm changeset and following the prompts. (select vite-plugin-svelte, select patch, write a short note like "changed loglevel of output unchanged message to debug to reduce verbosity")

Changeset created, waiting for approval.

@Augasty
Copy link

Augasty commented Nov 20, 2023

Hi @Radiergummi and @dominikg, I was trying to solve the issue, found the bug and after solving it, I came to see that @Radiergummi has already raised a PR.
I am not entirely sure whether I should raise my own PR (This is my first try at open source contribution, so please excuse me if I am doing something wrong).

So, I am uploading my changes anyway, thanks.

@dominikg
Copy link
Member

Thank you @Radiergummi !

@Augasty raising a duplicate PR is usually not a good idea, but participating in issues and PRs is. Your PR itself looks fine too, but this one is going ahead as it was first.

@Augasty
Copy link

Augasty commented Nov 20, 2023

Absolutely okay with it. And thanks a lot for feedback.

@dominikg dominikg merged commit f2dfba3 into sveltejs:main Nov 20, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
@Radiergummi Radiergummi deleted the radiergummi/lower-log-level-for-hot-update-equality-to-debug branch November 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress "ignoring compiler output js change..." message unless debugging enabled
3 participants