Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update peerDependencies to require Jest 27 #56

Merged

Conversation

rossyman
Copy link
Contributor

Add support for v27 of Jest within svelte-jester.

Need

Changelog

  • Updated dependency requirements

Due-diligence

  • Introspectively ran internal tests and validated that there was no regression.

Screenshot 2021-07-28 at 20 21 42

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@benmccann benmccann changed the title Add v27 Support for Jest chore: update peerDependencies to require Jest 27 Aug 2, 2021
@benmccann benmccann merged commit 1052bed into svelteness:master Aug 2, 2021
@benmccann
Copy link
Collaborator

I went ahead and merged this so that I could send a PR for async transforms that depends on it

@sebastianrothe
Copy link
Collaborator

sebastianrothe commented Aug 2, 2021

I went ahead and merged this so that I could send a PR for async transforms that depends on it

I'm so sorry, but I disabled most of the tests with one of my older commits :(

https://github.com/mihar-22/svelte-jester/pull/53/files#diff-f638d82910738e07f34f9ca5c6cb2a01c223570f9c2425ddf60f61e2070c169dR64

@benmccann
Copy link
Collaborator

I'm so sorry, but I disabled most of the tests with one of my older commits :(

I'm not understanding. Disabled how? By accident or on purpose?

@sebastianrothe
Copy link
Collaborator

I'm so sorry, but I disabled most of the tests with one of my older commits :(

I'm not understanding. Disabled how? By accident or on purpose?

By accident. I was testing this one test in particular and forget to take out the it.only( before creating the pull request.

@sebastianrothe
Copy link
Collaborator

I'm so sorry, but I disabled most of the tests with one of my older commits :(

I'm not understanding. Disabled how? By accident or on purpose?

By accident. I was testing this one test in particular and forget to take out the it.only( before creating the pull request.

I'm trying to figure out, why the tests are failing now.

@sebastianrothe
Copy link
Collaborator

I'm so sorry, but I disabled most of the tests with one of my older commits :(

I'm not understanding. Disabled how? By accident or on purpose?

By accident. I was testing this one test in particular and forget to take out the it.only( before creating the pull request.

I'm trying to figure out, why the tests are failing now.

fixed in #57

@rossyman rossyman deleted the enhancement/support-v27-of-jest branch August 10, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants