Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces own pascal case function with sindresorhus/camelcase #6

Merged
merged 1 commit into from Oct 4, 2020

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 4, 2020

Description

Replaces the hand-rolled to-pascal-case function with a readily available one to reduce maintenance/ increase reliability.

Motivation and Context

We rolled our own because sindresorhus/camelcase didn't support unicode yet - but nowadays it does (since March/ April 2019 when this PR got merged & released).

How Has This Been Tested?

  • automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the chore/replace-own-pascal-case-with-camelcase-lib branch from f116694 to 09da21b Compare October 4, 2020 16:45
@sverweij sverweij merged commit 8e8f214 into master Oct 4, 2020
@sverweij sverweij deleted the chore/replace-own-pascal-case-with-camelcase-lib branch October 4, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant