Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chalk with colorette #1511

Merged
merged 1 commit into from Aug 4, 2021
Merged

Replace chalk with colorette #1511

merged 1 commit into from Aug 4, 2021

Conversation

ludofischer
Copy link
Contributor

@ludofischer ludofischer commented Aug 3, 2021

Replace chalk with colorette to remove 5 deps from production installl:
ansi-styles, supports-color, color-convert, has-flag, color-name.

Also reduce deps when using PostCSS and SVGO together, since PostCSS
uses colorette.

Tested with yarn install svgo.

@ludofischer ludofischer changed the title Replace chalk with colorette Reduce dependencies Aug 3, 2021
@TrySound TrySound changed the title Reduce dependencies Replace chalk with colorette Aug 3, 2021
@ludofischer
Copy link
Contributor Author

Sorry, the original PR had a bunch of mistakes in it. I've fixed the linting and moved colorette to dependencies instead of devDependencies.

Remove 5 deps from production install:
`ansi-styles`, `supports-color`, `color-convert`, `has-flag`, `color-name`.

Also reduce deps when using PostCSS and SVGO together, since PostCSS
uses colorette.

Tested with `yarn install svgo`.
Copy link

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I also noticed that svgo uses chalk and wanted to submit a similar PR 😅 Good job!

I am not a maintainer, yet I'll add an approval review to boost this PR 🚀

@TrySound TrySound merged commit c4ae19e into svg:master Aug 4, 2021
@TrySound
Copy link
Member

TrySound commented Aug 4, 2021

Thank you!

@ludofischer ludofischer deleted the colorette branch August 4, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants