Refactor removeUselessStrokeAndFill #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is a little messy. Will be better when we drop node 12 support and use optional chaining. - migrated to visitor plugin api - covered with types - get rid from patching params as plugin state - replaced many node.computedAttr() with style manager - enabled and fixed removeNone param test (was merged as muted back in 2017) - added ability to return null and not run visitor in plugins
TrySound
referenced
this pull request
Aug 29, 2021
matheus1lva
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is a little messy. Will be better when we drop node 12 support
and use optional chaining.