Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mergeStyles #1575

Merged
merged 1 commit into from Sep 23, 2021
Merged

Refactor mergeStyles #1575

merged 1 commit into from Sep 23, 2021

Conversation

TrySound
Copy link
Member

  • covered with tsdoc
  • replace another closestByName usage with visitSkip symbol to skip
    subtree instead of skipping element by ancestor
  • added one more test case

Better review with hidden whitespaces as most code just got bigger indent.

- covered with tsdoc
- replace another closestByName usage with visitSkip symbol to skip
  subtree instead of skipping element by ancestor

Better review with hidden whitespaces as most code just got bigger indent.
Copy link
Collaborator

@omgovich omgovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@TrySound TrySound merged commit 9ebff13 into master Sep 23, 2021
@TrySound TrySound deleted the refactor-merge-styles branch September 23, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants