fix(plugin): removeAttrs: warn without attrs #1582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1560 and should fix #1581. The PR attempt to fix an issue when the plugin is called without the
attrs
option. The code expects that theattrs
option is present and throw an error when it's not because we end up havingattrs = [undefined]
(see below).Technically this should be an error but it would be a breaking change. We can start by introducing a warning (what this PR does) and in a future major version throw an error. I added a test where input = output when
attrs
is not provided i.e. noop.