Support es modules #1583
Merged
Support es modules #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #1579 In config of course. Projects with type:module can now use modules to export config ```js export default { plugins: [] } ``` Also added support for resolving svgo.config.mjs and svgo.config.cjs. Moved loadConfig tests to svgo-node tests. mjs test is skipped for now in node 10, just don't use modules there
TrySound
requested review from
omgovich,
deepsweet,
matheus1lva and
renatorib
|
Wow, worked! |
matheus1lva
reviewed
Sep 21, 2021
| try { | ||
| // dynamic import expects file url instead of path and may fail | ||
| // when windows path is provided | ||
| const { default: imported } = await import(pathToFileURL(configFile)); |
There was a problem hiding this comment.
Just a comment here: ESM can be imported using dynamic import without any more work to get it working?
There was a problem hiding this comment.
With current lts yes. But we still supported node 10 until next major release so we fallback to require in case of error.
matheus1lva
approved these changes
Sep 21, 2021
omgovich
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1579
In config of course. Projects with type:module can now use modules to
export config
Also added support for resolving svgo.config.mjs and svgo.config.cjs.
Moved loadConfig tests to svgo-node tests.
mjs test is skipped for now in node 10, just don't use modules there
cc @ai