Fix prefixIds plugin to properly handle url()s in style="..." #1592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great tool!
prefixIds
plugin currently breaks url()-links insidestyle
attributes:will generate
<g style=""/>
. Seems likeprefixIds
assumes that attribute's whole value might beurl()
, but this is not the case for thestyle
attribute.This fix solves the issue by preserving all attribute's content other than #id inside url(). It also adds some more tests for the
prefixIds
plugin.